Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: Update redacted types according to changes in room version 11 #1619

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Aug 12, 2023

MSC2176 / MSC3821 (parts of MSC3820) / Spec PR

This changes just the types and the algorithms in the RedactContent implementations. A follow up PR will change the algorithm for the canonical_json module.

Note that RedactedRoomRedactionEventContent and RedactedRoomCreateEventContent and their redaction algorithms are already updated in #1616 and #1617, respectively.


Preview Removed

@zecakeh zecakeh requested a review from a team August 12, 2023 14:03
@jplatte
Copy link
Member

jplatte commented Aug 14, 2023

Spec PR link is not filled in 😅

@zecakeh
Copy link
Contributor Author

zecakeh commented Aug 14, 2023

Woops, fixed.

@zecakeh zecakeh force-pushed the zecakeh/events-redaction-room-v11 branch from 7898e72 to 2fa87ad Compare August 14, 2023 15:58
@zecakeh
Copy link
Contributor Author

zecakeh commented Aug 14, 2023

Rebased on main to fix conflicts

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zecakeh
Copy link
Contributor Author

zecakeh commented Aug 16, 2023

Oh the first commit's description doesn't mention the proper type 😓

@zecakeh zecakeh force-pushed the zecakeh/events-redaction-room-v11 branch from 2fa87ad to 1ddb6e7 Compare August 16, 2023 12:49
@zecakeh zecakeh force-pushed the zecakeh/events-redaction-room-v11 branch from 1ddb6e7 to 7ee6063 Compare August 16, 2023 12:50
@zecakeh zecakeh enabled auto-merge (rebase) August 16, 2023 12:50
@zecakeh zecakeh merged commit 6fcd813 into main Aug 16, 2023
20 of 21 checks passed
@jplatte jplatte deleted the zecakeh/events-redaction-room-v11 branch August 16, 2023 12:56
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants