Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize support for private read receipts #1319

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Stabilize support for private read receipts #1319

merged 2 commits into from
Oct 1, 2022

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 1, 2022 •
edited by github-actions bot
Loading

@zecakeh zecakeh requested a review from a team October 1, 2022 09:10
ShadowJonathan
ShadowJonathan approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@ShadowJonathan ShadowJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zecakeh zecakeh force-pushed the zecakeh/private-read-receipts branch from ffc2c6f to cca9c31 Compare October 1, 2022 09:15
@zecakeh
Copy link
Contributor Author

zecakeh commented Oct 1, 2022 •
edited
Loading

The force push was to solve a merge conflict in the changelog.

@zecakeh zecakeh enabled auto-merge (rebase) October 1, 2022 09:15
@ShadowJonathan
Copy link
Member

Still looks good.

Dont forget to do a final grep on the MSC number in the codebase, when you do these PRs, to be sure you removed any and all references to the MSC :)

@zecakeh zecakeh merged commit c141b7d into main Oct 1, 2022
@zecakeh zecakeh deleted the zecakeh/private-read-receipts branch October 1, 2022 09:34
@zecakeh
Copy link
Contributor Author

zecakeh commented Oct 1, 2022

Dont forget to do a final grep on the MSC number in the codebase, when you do these PRs, to be sure you removed any and all references to the MSC :)

That's usually what I do to make there PRs in the first place 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadowJonathan ShadowJonathan ShadowJonathan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zecakeh @ShadowJonathan