Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named parameters when using the JSON-RPC interface #51

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

ruimarinho
Copy link
Owner

Continuation of #33 with improved tests, README updates and version.exec fixes.

This PR adds support for JSON RPC named parameters (only available in Bitcoin Core >=0.14.x).

const balance = await new Client(config.bitcoind).getBalance({
  account: '*',
  minconf: 0
});

// Same as:
const balance = await new Client(config.bitcoind).getBalance('*', 0);

const mainWalletBalance = await client.getBalance({ account: '*', minconf: 0 });
const testWalletBalance = await client.getBalance({ account: 'test', minconf: 0 });

mainWalletBalance.should.not.equal(testWalletBalance);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of adding an extra assert to test that, for legacy reasons:
client.getBalance({ account: '*', minconf: 0 }) equals client.getBalance('*', 0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants