Update dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruimarinho
force-pushed
the
enhancement/update-dependencies
branch
from
c22e105
to
2469ac5
Compare
ruimarinho
force-pushed
the
enhancement/update-dependencies
branch
3 times, most recently
from
e27540c
to
31d2f77
Compare
joaopaulofonseca
requested changes
Nov 20, 2017
package.json
Outdated
| "nock": "^8.0.0", | ||
| "nyc": "^8.1.0", | ||
| "mocha": "^4.0.1", | ||
| "nock": "^9.0.27", |
There was a problem hiding this comment.
Maybe use version 9.1.0?
package.json
Outdated
| "nyc": "^8.1.0", | ||
| "mocha": "^4.0.1", | ||
| "nock": "^9.0.27", | ||
| "nyc": "^11.2.1", |
There was a problem hiding this comment.
Maybe use version 11.3.0?
package.json
Outdated
| @@ -72,7 +72,7 @@ | |||
| "sourceMap": false | |||
| }, | |||
| "options": { | |||
| "mocha": "--compilers js:babel-register --timeout 20000 --recursive --require should" | |||
| "mocha": "--require @babel/register --require @babel/polyfill --timeout 20000 --recursive --require should" | |||
There was a problem hiding this comment.
Remove extra space before --require @babel/polyfill.
| @@ -31,6 +31,10 @@ function obfuscateResponseBody(body, method) { | |||
| */ | |||
|
|
|||
| function obfuscateResponse(request, instance) { | |||
| if (request.type !== 'response') { | |||
There was a problem hiding this comment.
Separate commits for this and its tests.
ruimarinho
force-pushed
the
enhancement/update-dependencies
branch
from
31d2f77
to
7a052db
Compare
joaopaulofonseca
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly upgrading babel@7.