Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camelcase consistency for mempool calls #20

Closed
wants to merge 1 commit into from
Closed

Fix camelcase consistency for mempool calls #20

wants to merge 1 commit into from

Conversation

johnbailon
Copy link

Small fix on camelCase consistency for mempool call.

@ruimarinho
Copy link
Owner

I see that Travis tests are failing but it's unrelated to your PR (should have used a fixed Docker image). How angry does this inconsistency makes you feel :-)? This would require a major version due to the breaking change..

@johnbailon
Copy link
Author

@ruimarinho haha, don't sweat it. I ran into it and thought it should make for a nice pull request. Feel free to wait for other fixes to make the major version bump worth it.

@ruimarinho
Copy link
Owner

This will likely be merged when the returned numbers are changed to be returned as strings.

@ruimarinho
Copy link
Owner

@johnbailon I'm more inclined to rename the other methods to Mempool instead of MemPool.

@johnbailon
Copy link
Author

@ruimarinho why so? Do note that bitcoind's docs use MemPool.

@promag
Copy link

promag commented Feb 13, 2017

The fix should be s/MemPool/Mempool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants