Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setMinDocCount and setExtendedBounds options #947

Merged
merged 1 commit into from
Oct 7, 2015

Conversation

markeilander
Copy link
Contributor

Changed the correct file this time ;-)

@markeilander markeilander changed the title Update DateHistogram.php Added setMinDocCount and setExtendedBounds options Oct 7, 2015
ruflin added a commit that referenced this pull request Oct 7, 2015
Added setMinDocCount and setExtendedBounds options
@ruflin ruflin merged commit cb1cafe into ruflin:master Oct 7, 2015
@ruflin
Copy link
Owner

ruflin commented Oct 7, 2015

Merged, thx.

@CedCannes
Copy link

@markeilander thank you for your work , I just need to use " extended_bound " 👍
By cons it seems that the function setMinDocCount already existed in Histogram

https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Aggregation/Histogram.php#L55

There are two functions to do the same...

@ruflin
Copy link
Owner

ruflin commented Oct 8, 2015

@CedCannes Good point. I forgot about this one. @markeilander Can you remove the duplicate or use it as proxy? Because I like the "short" version naming.

@markeilander
Copy link
Contributor Author

Made a new pull request: #950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants