-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Script File feature #902
Conversation
{ | ||
/** | ||
* @param array|null $params | ||
* @param null $id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@param string $id
@nicolassing Looks good, thanks. |
@nicolassing Any updates here? I plan to do a release today and would like to include this. Make sure merge master as quite a few changes went into master. |
@ruflin I've added a functional test. But this functional test will not work without the script file. I've updated elasticsearch configuration and created a script file (calculate-distance.groovy) in test/data/ but this script file must be in /etc/elasticsearch/scripts. I don't know how to do this with Docker and Vagrant :( |
Thx, I will have a look. |
@nicolassing After fighting a little bit with ansible I got it running here: #914 I had to move the files from the data to the config/scripts directory as elasticsearch loads the files from there. |
I merged my pull request with the changes. Thanks for the contribution. |
👍 Someday i'd learn how to really use ansible, vagrant, docker, etc ... Someday ... 😄 |
You can directly jump to docker ;-) |
Hello,
I've added scripting file-base feature in addition of inline scripting.