-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build and development environment #852
Conversation
@im-denisenko Can you please have a look at this and also try it out locally (see commands in Makefile). You need docker-compose installed. There are still 2 tests failing and socket_create is missing. I will fix the failing test issue now. |
Every new command in Dockerfile will create new layer. It's ok, but minimize that number is good practice. I would suggest combine them like following:
|
@im-denisenko Having a build for every line is one of the reasons I love Docker. Merging the line as you mentioned above speeds up the installation but I would like to keep it one line for each command at the moment, because I still changing and playing around with the docker file. Having one line per command means I can leverage the cache much better. As soon as the Docker file is more stable, we should move to merging the lines as you mentioned above. |
Docker build and development environment
Introduction of Docker as the build and development environment.
I hope to use this in the future also for Travis / CI builds.