Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ResponseException catch in Type::getDocument() #704

Closed
wants to merge 0 commits into from
Closed

Remove ResponseException catch in Type::getDocument() #704

wants to merge 0 commits into from

Conversation

rmruano
Copy link
Contributor

@rmruano rmruano commented Oct 15, 2014

Check the consequences of completely removing the ResponseException catch in tests (as discussed at #687)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 2bf89c4 on rmruano:master into 0d2400b on ruflin:master.

@rmruano rmruano closed this Oct 29, 2014
@ruflin
Copy link
Owner

ruflin commented Oct 31, 2014

I assume there is nothing to be done for me here, right?

@rmruano
Copy link
Contributor Author

rmruano commented Oct 31, 2014

No, it was just to check the tests. #713 PR replaces this one.

@ruflin
Copy link
Owner

ruflin commented Oct 31, 2014

Ok, perfect. Check my comment in #713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmruano @coveralls @ruflin