Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 8.0.0 GA release #2215

Merged
merged 5 commits into from
May 29, 2024
Merged

Prepare 8.0.0 GA release #2215

merged 5 commits into from
May 29, 2024

Conversation

ruflin
Copy link
Owner

@ruflin ruflin commented May 28, 2024

No description provided.

@ruflin
Copy link
Owner Author

ruflin commented May 28, 2024

@sidz @thePanz Would be great to get your eyes on this one as I plan to tag 8.0.0 as soon as this PR is merged.

@ruflin
Copy link
Owner Author

ruflin commented May 28, 2024

Do we need any update to the branch alias? https://github.com/ruflin/Elastica/blob/8.x/composer.json#L56

@ruflin ruflin mentioned this pull request May 28, 2024
Closed
6 tasks
@sidz
Copy link
Contributor

sidz commented May 28, 2024

I'd say that we don't need to have branch-alias at all @ruflin .

sidz
sidz approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@sidz sidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ruflin
Copy link
Owner Author

ruflin commented May 28, 2024

I'd say that we don't need to have branch-alias at all @ruflin .

Should I get rid of it now or in a follow PR? @thePanz Do you remember why we had the branch alias? Because we had the main branch before?

thePanz
thePanz reviewed May 28, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
thePanz
thePanz reviewed May 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@thePanz
Copy link
Collaborator

thePanz commented May 28, 2024

I'd say that we don't need to have branch-alias at all @ruflin .

Should I get rid of it now or in a follow PR? @thePanz Do you remember why we had the branch alias? Because we had the main branch before?

yes, that's the reason why we had to use the alias.

OK for me to remove it in this PR (within an additional commit)

I added just two minor suggestions, feel free to apply them @ruflin

@thePanz
Copy link
Collaborator

thePanz commented May 29, 2024

LGTM @ruflin , let's squash the changelog commits before merging 👍

@ruflin ruflin merged commit 2fc446e into 8.x May 29, 2024
34 checks passed
@ruflin
Copy link
Owner Author

ruflin commented May 29, 2024

I was lazy and squashed it all into a single commit ;-)

@ruflin ruflin deleted the prepare-8.0.0-release branch May 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidz sidz sidz approved these changes

@thePanz thePanz thePanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @sidz @thePanz