-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DockerPHP AllowSymfonyFlexPlugin on phpuser for phpunit #2194
DockerPHP AllowSymfonyFlexPlugin on phpuser for phpunit #2194
Conversation
do not change compose.json
Can you share a bit more background (link or comment) on what this exactly does / allows? |
As noted, I really like the idea of docker fulfilling its role of abstracting the host's technical stack. After recovering the projects to work on the unit testing part, I executed make docker-start, then make docker-run-phpunit and I encountered this error, for which I propose this fix (see screenshot below). |
My initial reaction was, it seems like this is the wrong place but I just found out, 4 years ago we added this dependency to the project :-) Line 19 in 8bcb02d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. Can you add a quick note to the changelog?
Done ! |
move type of changes ok. |
@daminuxfork Thank you for the contribution! |
Allow (to false) SymfonyFlex plugin for phpuser on make docker-run-phpunit
Love tests on docker ;)