Fix PHPStan conditional return type on Search::count

[Jean-Beru]

When using Search::count method, PHPstan warns about using the result as an integer because it could also be a ResultSet.

This PR add a conditional return type depending on $fullResult param.

[ruflin]

@Jean-Beru Could you target this to 8.x and then we backport to 7.x? This ensures we always have the most recent changes in 8.x

[Jean-Beru]

Sure! It's done @ruflin

[ruflin]

Thanks @Jean-Beru It is ready to merge, there is only a slight problem. For some reason, Github states: "This branch has not been deployed". It seems CI did not run on this PR but it is running on other PR's like #2168 😕 @deguif Any ideas on your end? Normally I can "approve" for the first PR to run it, but it doesn't show the button 😢

[thePanz]

@ruflin maybe rebasing the branch again and pushing will trigger the pipelines?

The changes look good tho, we can merge this. Should we press the button? :)

[ruflin]

Thanks for the ping @thePanz I merge in main. I'm actually surprised I can push to this branch :-)

[thePanz]

@ruflin I guess that's because @Jean-Beru configured that the repo maintainers can push to it :)

I would suggest to "rebase" instead of merging it here: there is a configuration on the repo settings allowing to rebase from the UI directly :)

ps: I triggered the GigHub actions to run 👍

[Jean-Beru]

I totally forgot this PR 😅

Thanks for the rebase @ruflin. Also, I fixed the last CI fail

[ruflin]

I would suggest to "rebase" instead of merging it here: there is a configuration on the repo settings allowing to rebase from the UI directly :)

I didn't find this button so I jumped to the command line. I normally to a rebase but felt a bit "uncomfortable" doing it on someone else code. Seems like @Jean-Beru has it now all under control :-)

[Jean-Beru]

The change is trivial, I will rebase it in few minutes.

[Jean-Beru]

Done 🙂

[thePanz]

Merged, thanks @Jean-Beru !

[ruflin]

Thanks @Jean-Beru and @thePanz for getting this in!