Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more versions of ES #2155

Merged
merged 5 commits into from
Apr 11, 2023
Merged

added more versions of ES #2155

merged 5 commits into from
Apr 11, 2023

Conversation

oleg-andreyev
Copy link
Contributor

No description provided.

@oleg-andreyev oleg-andreyev marked this pull request as ready for review April 4, 2023 21:08
@oleg-andreyev
Copy link
Contributor Author

@ruflin one more PR that's adding more versions to CI

@@ -48,7 +48,19 @@ jobs:
elasticsearch: '7.15.2'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update this to 7.17.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

elasticsearch: '8.7.0'
experimental: false
- php: '8.1'
elasticsearch: '8.8.0-SNAPSHOT' # future version, allow to fail https://www.elastic.co/guide/en/elasticsearch///reference/master/release-notes-8.8.0.html
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to keep in mind, 8.8. could contain a breaking change that is still fixed before it goes stable. I like the idea of testing against snapshots at the same time these can be very flaky so I would rather not do it for the lib.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is marked as experimental so it's allowed to fail, and that was my goal.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually more worried about the parts were tests had to be adjusted for 8.8 because some thing changes (which might get reverted)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can revert it, it's not a problem, as long as we collect and see them (issues)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, keep it in. We can always cleanup afterwards. The docs you added are really good.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Could you also mention this in the changelog. I know, it only changes tests but it is still good to know for everyone that the test matrix has been updated!

@ruflin
Copy link
Owner

ruflin commented Apr 5, 2023

@oleg-andreyev Even though I approved, I would still like the changelog to be added ;-)

@ruflin ruflin merged commit b7fa526 into ruflin:8.x Apr 11, 2023
@ruflin
Copy link
Owner

ruflin commented Apr 11, 2023

Thanks @oleg-andreyev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants