-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added more versions of ES #2155
Conversation
…tIncomplete, updated phpunit.xml.dist
@ruflin one more PR that's adding more versions to CI |
@@ -48,7 +48,19 @@ jobs: | |||
elasticsearch: '7.15.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update this to 7.17.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
elasticsearch: '8.7.0' | ||
experimental: false | ||
- php: '8.1' | ||
elasticsearch: '8.8.0-SNAPSHOT' # future version, allow to fail https://www.elastic.co/guide/en/elasticsearch///reference/master/release-notes-8.8.0.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to keep in mind, 8.8. could contain a breaking change that is still fixed before it goes stable. I like the idea of testing against snapshots at the same time these can be very flaky so I would rather not do it for the lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is marked as experimental so it's allowed to fail, and that was my goal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually more worried about the parts were tests had to be adjusted for 8.8 because some thing changes (which might get reverted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert it, it's not a problem, as long as we collect and see them (issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, keep it in. We can always cleanup afterwards. The docs you added are really good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Could you also mention this in the changelog. I know, it only changes tests but it is still good to know for everyone that the test matrix has been updated!
@oleg-andreyev Even though I approved, I would still like the changelog to be added ;-) |
Thanks @oleg-andreyev |
No description provided.