Allow PHP 8.2 #2136
Merged
Allow PHP 8.2 #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
commented
Dec 14, 2022
CHANGELOG.md
Outdated
| ### Changed | ||
| ### Deprecated | ||
| ### Removed | ||
| * Dropped support for PHP <8.0 [#2131](https://github.com/ruflin/Elastica/pull/2131) |
There was a problem hiding this comment.
I've moved this entry since it is not really BC Break, if the user is using PHP < 8.0 it won't be able to use this version since composer won't allow it.
There was a problem hiding this comment.
I would still keep it under breaking change. Imagine a user goes to the changelog for 8.0 and wants to see what the breaking changes are. Nothing around 8.0 in it and then tries to deploy it but can't. Agree, the technical bits are in place but I hope users read the changelog before.
There was a problem hiding this comment.
I've reverted this change since it's not related to this PR, I hope users try their projects with the PHP version used in their servers, but well you'll never know 🙈
franmomu
force-pushed
the
allow_php_8.2
branch
from
61f705c to
9671f81
Compare
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for PHP 8.2