Remove deprecated classes #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Dec 8, 2022
| @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased](https://github.com/ruflin/Elastica/compare/7.3.0...master) | |||
| ### Backward Compatibility Breaks | |||
| * Dropped support for PHP <8.0 [#2131](https://github.com/ruflin/Elastica/pull/2131) | |||
| * Removed deprecated classes in 7.x [#2132](https://github.com/ruflin/Elastica/pull/2132) | |||
There was a problem hiding this comment.
I know the list might be long but I think it is worth for our users to list the classes in the changelog. Same for methods and variables that were removed. Like this, users don't have to look at the PR but only changelog to see what was removed.
If we want to go even one step further, we could add use now. Something like:
- Elastica\Processor\Convert removed -> use Elastica\Processor\ConvertProcessor instead
franmomu
force-pushed
the
remove_deprecated_classes
branch
from
e2cc4e6 to
25c770b
Compare
franmomu
force-pushed
the
remove_deprecated_classes
branch
from
25c770b to
3deb5ef
Compare
|
Thanks! |
ruflin
pushed a commit
that referenced
this pull request
Dec 15, 2022
Follow-up #2132 This PR removes deprecated methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all deprecated classes in
7.xbranch, there is still deprecated code to be removed/changed but I think it will be easier to review in another PR.