Prevent throwing JSONParseException when the response is empty. #2125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this issue when I wanted to check whether an index exists in the elastic.
Elastica uses HEAD requests to check whether the index exists or not, so the response body is empty.
This issue is handled inside the code by try-catch (getData function). But there were two reasons for this PR:
1- by this change, we can check if the response is empty, don't call the JSON parse function. So no exception will occur, and there isn't any need to catch it.
2- we use newrelic for distributed tracing and see many errors. ( newrelic agent collects all exceptions even though they are handled, and we want to keep this ability for better tracing )