Fix MoreLikeThis::setLike() allowing Document
#2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
commented
Jun 24, 2022
tests/Query/QueryStringTest.php
Outdated
| $str = \md5(\mt_rand()); | ||
| $str = uniqid(); |
There was a problem hiding this comment.
This change is because \md5() expects a string and \mt_rand() returns an int. The return value of \mt_rand() could also be casted to string, but instead I've used uniqid(), if cast is preferred, let me know.
franmomu
force-pushed
the
more_like_this_doc
branch
from
8961e4b to
84e52a0
Compare
ruflin
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MoreLikeThis::setLike()allowsDocumentas showed inElastica/tests/Query/MoreLikeThisTest.php
Lines 96 to 102 in cd552e1