Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit return annotation #2056

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add explicit return annotation #2056

merged 1 commit into from
Feb 23, 2022

Conversation

franmomu
Copy link
Contributor

When using Symfony >= 5.4, you get this kind of messages:

User Deprecated: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Elastica\Multi\ResultSet" now to avoid errors or add an explicit @return annotation to suppress this message.
User Deprecated: Method "Iterator::current()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Elastica\Multi\ResultSet" now to avoid errors or add an explicit @return annotation to suppress this message.

This PR avoids these messages.

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

It might seem overkill for this change as it is "only docs" but can you add an entry to the changelog? It will make it easier for others to find this change that have the same issue.

@franmomu
Copy link
Contributor Author

It might seem overkill for this change as it is "only docs" but can you add an entry to the changelog? It will make it easier for others to find this change that have the same issue.

Yeah, no problem 👍

@ruflin ruflin merged commit 3a19d82 into ruflin:master Feb 23, 2022
@ruflin
Copy link
Owner

ruflin commented Feb 23, 2022

Thank you!

@franmomu franmomu deleted the patch-1 branch February 23, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants