-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve https://github.com/ruflin/Elastica/issues/1737: handle 413 response #2055
Conversation
- adjusted Bulk, throw RequestEntityTooLargeException if response code 413
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry?
@Vetaxon Change LGTM. Could you add a changelog entry so we can get this in? |
@ruflin Hi. I have added updates to change the changelog.md, pls check. Also, when can we expect release of it? We need it for all our projects (more then 50). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around the release, I wonder as this is a bigger change if we should do a 7.2? @thePanz Thoughts?
Thanks for the changelog @Vetaxon Seems like you are hitting a conflict there and need to merge in or rebase on master. Could you also have a look at the comment from @thePanz here? #2055 (comment) Would be great to have a test covering this. |
added test BulkTest to check RequestEntityTooLargeExceptionTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Vetaxon for the tests, just a minor comment
@ruflin Hi, it seems PR is ready! Thanks |
Merged, thanks @Vetaxon ! |
@thePanz thanks a lot. Is it known when it can be release? |
@Vetaxon : 7.1.5 has been released now |
Resolve #1737