Fix CS bis #1706
Fix CS bis #1706
Conversation
deguif
force-pushed
the
fix-cs-bis
branch
2 times, most recently
from
5817b5b to
bcdf6f7
Compare
|
Not yet ready. I will add a new comment when it’s ready. |
| @@ -35,7 +35,7 @@ public function setBucketsPath(string $bucketsPath) | |||
| * | |||
| * @return $this | |||
There was a problem hiding this comment.
The return $this should be removed too :)
There was a problem hiding this comment.
Lets separate PR's which are fully automated and manual changes ;-)
| @@ -32,7 +32,7 @@ class HttpAdapter extends AbstractTransport | |||
| * | |||
| * @param Connection $connection | |||
| */ | |||
| public function __construct(Connection $connection = null, HttpAdapterInterface $httpAdapter) | |||
| public function __construct(?Connection $connection = null, HttpAdapterInterface $httpAdapter) | |||
There was a problem hiding this comment.
There is a glitch here, optional argument before a non optional argument.
There was a problem hiding this comment.
If we don't make it optional, would things break?
deguif
force-pushed
the
fix-cs-bis
branch
3 times, most recently
from
31bbeda to
d0213d4
Compare
|
@deguif Any chance you could update the PR description to contain a bit more details on the change? I'm aware the comment is linked but if someone comes back to this and asking why this all changed, would be nice to have it in a single place summarised. |
|
@ruflin Ok to merge! I'd squash the changes, just to keep the git history clean. wdyt? |
This PR add two new rules for coding style:
nullable_type_declaration_for_default_null_valueto enforce?declaration on nullable arguments. See ongoing discussion on Deprecate implicit nullable parameters php/php-src#3535no_alias_functionsto remove uses ofsizeof, ... PHP aliases functions.