Add total hits relation in ResultSelt #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a changelog entry and if possible add a small functional tests? |
deguif
force-pushed
the
add-total-hits-relation
branch
2 times, most recently
from
c0a013b to
79f0fd0
Compare
thePanz
reviewed
Nov 18, 2019
CHANGELOG.md
Outdated
| @@ -59,6 +59,7 @@ All notable changes to this project will be documented in this file based on the | |||
| ### Added | |||
|
|
|||
| * support for elasticsearch-php ^7.0 | |||
| * Added `\Elastica\ResultSet::getTotalHitsRelation()` to get relation for total hits [#1694](https://github.com/ruflin/Elastica/pull/1694) | |||
There was a problem hiding this comment.
This line should be added to the "unreleased" changes, after line 10!
There was a problem hiding this comment.
Oups, I messed up with the previous changes, I fixed that
deguif
force-pushed
the
add-total-hits-relation
branch
from
79f0fd0 to
dd05a94
Compare
|
@deguif Merged. Thanks for also cleaning up the other changelog entries, miss that in the PR review :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.