Restore request data in debug logging #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this went missing in the conversion and change LGTM. But it would be nice if @Tobion could comment if it was intentional. |
|
Any thoughts @Tobion? |
|
@neild3r I agree with |
neild3r
force-pushed
the
restore-request-debug-data
branch
from
0de5235 to
6757273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of #1661 I've not been getting the request body in my debug logs. The issue seems to be due to the the fact that it's not being converted into an array like it used to be.
I've not added to the CHANGELOG.md as this is fixing an issue that is already in that change log.