Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callable type hinting to Connection callback #1659

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Add callable type hinting to Connection callback #1659

merged 1 commit into from
Sep 5, 2019

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Sep 2, 2019

The $callback parameter is only used in ConnectionPool which already has the type hint.

@ruflin
Copy link
Owner

ruflin commented Sep 3, 2019

Code LGTM to me. Could you add a changelog entry just in case someone was using this in an unexpected way?

@franmomu franmomu force-pushed the add_type_hinting_to_connection branch from d5bd28e to e2077b1 Compare September 3, 2019 20:06
@franmomu
Copy link
Contributor Author

franmomu commented Sep 3, 2019

Sure!

@ruflin ruflin merged commit 838160b into ruflin:master Sep 5, 2019
@ruflin
Copy link
Owner

ruflin commented Sep 5, 2019

@franmomu Thanks for the contribution.

@franmomu franmomu deleted the add_type_hinting_to_connection branch September 5, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @ruflin