Added BucketSelector aggregation #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltehuebner
changed the title
* master: update to ES 6.5.2 and to LATEST PHP 7.3 official relase (ruflin#1552) Prepare for 6.1.0 release (ruflin#1547) test connection error (ruflin#1546) Add php73 support and Xdebug (ruflin#1545)
p365labs
requested changes
Dec 11, 2018
ruflin
reviewed
Dec 12, 2018
|
I hope I now resolved all your issues :) |
|
Are we using return types and scalar parameter types as |
|
@maltehuebner yep there will be a massive refactoring on that, so if u would like to update your PR you are welcome :) 👍 for the PR for me! |
p365labs
approved these changes
Dec 13, 2018
ruflin
requested changes
Dec 13, 2018
p365labs
requested changes
Dec 14, 2018
p365labs
approved these changes
Dec 15, 2018
|
@ruflin for me it's ok to be merged |
|
@p365labs Changelog still looks "interesting" to me? |
|
@ruflin yep u're right
@maltehuebner is still under a release and should be move to unreleased under "Added" |
* master: Update composer dependencies (ruflin#1567) Add Derivative Aggregation (ruflin#1553)
|
@ruflin now to me seems ok, what about u ? |
ruflin
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
BucketSelectoraggregation and wrote a small test.