Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Term Suggester, test multiple completion suggestions #1543

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

p365labs
Copy link
Collaborator

In reference #1541 I made some more tests, I also addedd a method for choosing the distance algorithm

@p365labs
Copy link
Collaborator Author

This PR in fact add a test in order to verify the #1541 to have a use case that cover that example.
I've also added a method

public function setStringDistanceAlgorithm($distanceAlgorithm)

and its test to include this option which was not in the class.

@ruflin
Copy link
Owner

ruflin commented Dec 3, 2018

Code LGTM. Want to add a changelog entry?

@p365labs
Copy link
Collaborator Author

p365labs commented Dec 3, 2018

@ruflin done :)

@ruflin ruflin merged commit 7232cd6 into ruflin:master Dec 3, 2018
@p365labs p365labs deleted the add_suggestion_bug branch December 3, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants