Added updateByQuery endpoint #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmoreram
commented
May 25, 2018
•
mmoreram
commented
- Added Changelog entry as well under Added block
|
Solves #1103 |
ruflin
reviewed
May 28, 2018
test/Elastica/IndexTest.php
Outdated
| @@ -290,6 +291,76 @@ public function testDeleteByQueryWithQueryAndOptions() | |||
| $this->assertEquals(0, $response->count()); | |||
| } | |||
|
|
|||
| /** | |||
| * @group functional | |||
| * @group mmoreram | |||
There was a problem hiding this comment.
What does the second group here mean and what is it for?
test/Elastica/IndexTest.php
Outdated
| $response = $index->search('nicolas'); | ||
| $this->assertEquals(1, $response->count()); | ||
|
|
||
| // Delete first document |
There was a problem hiding this comment.
This only renames it and does not delete it?
test/Elastica/IndexTest.php
Outdated
|
|
||
| $index->refresh(); | ||
|
|
||
| // Makes sure, document is deleted |
There was a problem hiding this comment.
See comment above, it makes sure document is renamed.
test/Elastica/IndexTest.php
Outdated
| $response = $index->search('nicolas'); | ||
| $this->assertEquals(1, $response->count()); | ||
|
|
||
| // Delete first document |
test/Elastica/IndexTest.php
Outdated
|
|
||
| $index->refresh(); | ||
|
|
||
| // Makes sure, document is deleted |
|
Fixed all docs. I'm sorry, my mistake I didn't check properly tests :) |
|
@mmoreram Thanks a lot for the contribution. |
|
@ruflin thanks to you, for this library :=) When do you expect you will release next stable version? |
|
Here you go: http://elastica.io/2018/05/29/release-6-dot-0-2/ |
|
@ruflin WEEEE That deserves a beer if you come to Barcelona ! :D Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.