Add sum_bucket & avg_bucket aggregations #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josselinh
force-pushed
the
sum_avg_bucket
branch
from
e831f39 to
69a3c20
Compare
|
Just FYI, I have ElasticSearch 5.6 |
|
Perfect timing as we need @ruflin Please consider this PR before releasing 5.3.1 :) |
|
@josselinh Can you add some tests to this and a CHANGELOG? Also it would be great to also have this in master. I suggest to have first a PR against master and then cherry pick it to 5.x. |
josselinh
force-pushed
the
sum_avg_bucket
branch
2 times, most recently
from
1b20dcd to
13a75ce
Compare
josselinh
force-pushed
the
sum_avg_bucket
branch
from
13a75ce to
68d81e0
Compare
|
Hello @ruflin, |
|
@josselinh Thanks a lot for the contribution and also the tests. Can you directly open the PR against master to make sure we don't forget about it and have all the features from 5.x also in master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ruflin
I need sum_bucket & avg_bucket, so I added them.
Hope it's ok
#1279