Removed CrossIndex Class #1411
Merged
Removed CrossIndex Class #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@p365labs Could you add a CHANGELOG entry? |
|
yep sorry |
p365labs
force-pushed
the
remove_cross_index
branch
from
fa4d154 to
33d38cd
Compare
|
@ruflin done :) |
ruflin
reviewed
Nov 14, 2017
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file based on the | |||
|
|
|||
| ### Backward Compatibility Breaks | |||
| - Return the [_source of inner hit nested](https://github.com/elastic/elasticsearch/pull/26982) as is without wrapping it into its full path context [#1398](https://github.com/ruflin/Elastica/pull/1398) | |||
| - Removed CrossIndex Class as from now use Reindex. | |||
There was a problem hiding this comment.
Sorry to be picky, but could you add the PR number and a link to the ES reindex docs?
p365labs
force-pushed
the
remove_cross_index
branch
from
33d38cd to
6fc28a0
Compare
|
no problem done |
ruflin
approved these changes
Nov 14, 2017
p365labs
force-pushed
the
remove_cross_index
branch
from
6fc28a0 to
a7cabfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated CrossIndex, use Reindex. Issue #1404