In QueryString cannot use [fields] parameter in conjunction with [default_field] #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p365labs
force-pushed
the
es6_default_field_and_fields
branch
from
db8b09c to
b3ae3a3
Compare
p365labs
changed the title
|
Hi @ruflin I changed the title in [WIP] as I have to inspect why some tests fails on travis. Wait on merging this one. TNX |
|
The problem seems that the Exception return query_validation_exception not in the same position of the array. Instead of using assertEquals and validate the value of a specific position $error['failed_shards'][0]['reason']['caused_by']['type'] I tried assertContains; like that seem to work. Waiting for tests to execute on Travis :) |
p365labs
force-pushed
the
es6_default_field_and_fields
branch
3 times, most recently
from
5a4dc6d to
37aa08b
Compare
|
@p365labs CI is green, but the usual changelog conflicts. |
ruflin
approved these changes
Aug 17, 2017
…junction with default_field
p365labs
force-pushed
the
es6_default_field_and_fields
branch
from
37aa08b to
4fe418a
Compare
p365labs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In QueryString cannot use anymore [fields] parameter in conjunction with [default_field]. There was a test failing because of an exception : QueryValidationException
After having a look a the docs on Es6 Breaking changes I did not find anything reporting this BC, the only way to check it is having a look at Elasticsearch 6.0+ source code.
Inside QueryStringQueryBuilderTests.java there a new test testDefaultFieldsWithFields which checks exactly if both parameters are set and in case raise a QueryValidationException.
I also implement a test to check for that Exception.