-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span queries #1319
Add span queries #1319
Conversation
#1320 is now merged. This probably needs rebase now. |
I've rebased and squashed my work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See my minor comment. This could be applied to all setters in the PR.
For field_masking_span agree that we can tackle that in case someone needs it actually.
*/ | ||
public function setLittle(AbstractSpanQuery $little) | ||
{ | ||
$this->setParam('little', $little); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normal have a return $this->setParam('little', $little);
in here so all setters return the object itself. This allows for chaining functions.
Ok, fixed all the setters in SpanContaining, SpanNot, SpanWithin and SpanNear (missed in #1320) |
@alekitto In the diff Builder.php shows up and I'm not sure why? |
BTW: Could you also add an entry to the changelog? |
Builder.php is an empty file, I probably deleted it without noticing. |
Argh, it seems some things got mixed up in the Changelog :-( The reason an additional entry is needed because just yesterday happened a release. So this goes into the next release. |
I just pushed a change to the CHANGELOG to bring it up-to-date. Make sure to get the most recent one in before updating it. |
👍 Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Waiting for green.
Fixes #1316