Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of neccessary scroll pages to skip useless last request #1273

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Keep track of neccessary scroll pages to skip useless last request #1273

merged 1 commit into from
Mar 20, 2017

Conversation

Tobion
Copy link
Collaborator

@Tobion Tobion commented Mar 16, 2017

Fixes #1234

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changelog entry? :-)

*
* @var array
*/
protected $_options = [null, null, null];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search type was never used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got removed before already with es upgrade

@Tobion
Copy link
Collaborator Author

Tobion commented Mar 20, 2017

Added changelog

@ruflin ruflin merged commit ec75c5c into ruflin:master Mar 20, 2017
@ruflin
Copy link
Owner

ruflin commented Mar 20, 2017

@Tobion Thanks, merged.

@Tobion Tobion deleted the scroll-optimization branch March 20, 2017 12:27
mhernik pushed a commit to mhernik/Elastica that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants