move test files to decrease directory depths #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Mar 15, 2017
composer.json
Outdated
| @@ -13,11 +13,11 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.6.0", | |||
| "psr/log": "~1.0" | |||
There was a problem hiding this comment.
Could we move the changes to these 3 lines to an other PR? I prefer not to mix the heavy moving of files with these "dependency" logic changes.
ruflin
approved these changes
Mar 15, 2017
|
@Tobion Merged. Thanks. |
mhernik
pushed a commit
to mhernik/Elastica
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JSONTestand the rest of the test files were at different locations. I moved all the files to the shorter directory structure which decreases the depths.Fixes #715
Doing the same thing for the src is not worth it and will just complicate git history.