Fix AnalyzeAPI with 'explain' parameter #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 would be nice if you could add a note to the changelog file |
|
@Tobion : Changelog added |
ruflin
reviewed
Feb 21, 2017
CHANGELOG.md
Outdated
| @@ -11,6 +11,8 @@ All notable changes to this project will be documented in this file based on the | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| - added support for the "explain" flag of AnalyzeAPI | |||
There was a problem hiding this comment.
@thePanz Could you also add the PR number behind it? We missed it in the recent changelog entries but I want to add it again as it makes reading changelogs easier as you can jump to the PR directly.
There was a problem hiding this comment.
@ruflin PR number and link added. Does it work OK for you?
ruflin
approved these changes
Feb 21, 2017
|
@thePanz LGTM. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ElasticSearch AnalyzeAPI has an "explain" parameter to gather further details about the performed analysis on a text content.
Unfortunately the ElasticSearch response is different when such parameter is set or not set.
See https://www.elastic.co/guide/en/elasticsearch/reference/5.2/_explain_analyze.html
and https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html.
The format "explain = true" is consistent in the 5.x major release.