Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for search option 'request_cache' #1243

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

ilanrivers
Copy link
Contributor

No description provided.

@ruflin
Copy link
Owner

ruflin commented Feb 2, 2017

@ilanrivers Thanks for the contribution. Could you also add a quick integration test for this one?

@ilanrivers
Copy link
Contributor Author

@ruflin Where exactly would this best fit? I do not see any other integration test for the other options.

@ruflin
Copy link
Owner

ruflin commented Feb 2, 2017

I think it should be in https://github.com/ruflin/Elastica/blob/master/test/lib/Elastica/Test/SearchTest.php There seem to be at least some tests which cover other constants.

@Tobion
Copy link
Collaborator

Tobion commented Mar 13, 2017

I don't think this needs a test because it's difficult to test if ES used a cache or not internally which this flag controls. So this is good to merge IMO.

@Zyqsempai
Copy link
Contributor

Guys we need to merge it, it is a really long awaited feature.
Tests are not needed here, they can be only formal, "Request passed or not".

@ruflin
Copy link
Owner

ruflin commented Mar 14, 2017

I'm ok with merging it. But we need a CHANGELOG entry. Either @ilanrivers has time to do it or @Zyqsempai or @Tobion perhaps have the time to do a follow up PR with the CHANGELOG? Or I can do it next week ... @Tobion Feel free to merge it.

@Tobion Tobion merged commit c7939d1 into ruflin:master Mar 14, 2017
Tobion added a commit that referenced this pull request Mar 14, 2017
Zyqsempai pushed a commit to Zyqsempai/Elastica that referenced this pull request Mar 14, 2017
@Tobion
Copy link
Collaborator

Tobion commented Mar 14, 2017

Added the changelog

mhernik pushed a commit to mhernik/Elastica that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants