store_fields don'textract values from the _source, use mapping 'store' (#1184) #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Nov 12, 2016
| @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file based on the | |||
|
|
|||
| ### Backward Compatibility Fixes | |||
| - Updated Elastica\Test\Suggest\CompletionTest now payload and output are removed | |||
| - Updated Elastica\Test\TypeTest::testGetDocumentWithFieldsSelection The stored_fields parameter will only return stored fields — it will no longer extract values from the _source | |||
There was a problem hiding this comment.
I think when we just update tests and don't to any chances to the actual code, we don't need the changelog normally. Going to merge it anyways ;-)
Zyqsempai
pushed a commit
to Zyqsempai/Elastica
that referenced
this pull request
Nov 21, 2016
* fielddata_fields has been deprecated in ES5, use parameter docvalue_fields instead (ruflin#1184) * Fix Set fielddata=true on [answer] (ruflin#1184) Change to official docker image (ruflin#1210) * Switch test environment to official docker image. * Disable tests with multiple elasticsearch instances. Update PHPUnit to the most recent version (ruflin#1211) Prepare release 5.0.0-beta1 (ruflin#1212) updated CompletionTest, payload and output are removed from completion suggester (ruflin#1184) (ruflin#1213) store_fields it will no longer extract values from the _source, use mapping 'store' (ruflin#1184) (ruflin#1215) update tests : use text or keyword instead of string and use boolean for store instaed yes/no (ruflin#1184) (ruflin#1218) remove shutdown Node|Cluster as _shutdown has been removed (ruflin#1184) (ruflin#1220) Squashed commits - Changed "text" field to "prefix" in suggestions - changed in ElasticSearch 5.0 - Changed "text" field to "prefix" in suggestions - changed in ElasticSearch 5.0
Zyqsempai
pushed a commit
to Zyqsempai/Elastica
that referenced
this pull request
Nov 21, 2016
* fielddata_fields has been deprecated in ES5, use parameter docvalue_fields instead (ruflin#1184) * Fix Set fielddata=true on [answer] (ruflin#1184) Change to official docker image (ruflin#1210) * Switch test environment to official docker image. * Disable tests with multiple elasticsearch instances. Update PHPUnit to the most recent version (ruflin#1211) Prepare release 5.0.0-beta1 (ruflin#1212) updated CompletionTest, payload and output are removed from completion suggester (ruflin#1184) (ruflin#1213) store_fields it will no longer extract values from the _source, use mapping 'store' (ruflin#1184) (ruflin#1215) update tests : use text or keyword instead of string and use boolean for store instaed yes/no (ruflin#1184) (ruflin#1218) remove shutdown Node|Cluster as _shutdown has been removed (ruflin#1184) (ruflin#1220) Squashed commits - Changed "text" field to "prefix" in suggestions - changed in ElasticSearch 5.0 - Changed "text" field to "prefix" in suggestions - changed in ElasticSearch 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stored_fields parameter will only return stored fields — it will no longer extract values from the _source.
I've updated the test in \Elastica\Test\TypeTest.php::testGetDocumentWithFieldsSelection, there was the need to have "stored" ('store' => 'yes') the fields extracted from the Docuement.
https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_50_search_changes.html#_literal_fields_literal_parameter