Search: add support for terminate_after option #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also adds simple test for the option - breaks out invalid option test into a separate test so that if the other options become invalid their exceptions will be detected
|
Thanks for the addition. LGTM. Could you please also update the CHANGELOG.md? |
|
Changelog updated |
|
@gibrown Thx. It seems your branch has a conflict with master. Probably there is a conflict in the Changelog. Could you rebase on top of master and resolve the conflict? |
- also adds simple test for the option - breaks out invalid option test into a separate test so that if the other options become invalid their exceptions will be detected
|
Sorry about that. I think it should be all set. |
|
@gibrown Merged. Thanks a lot for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137