[DX] Version method #1152
Merged
[DX] Version method #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-andreyev
force-pushed
the
version-method
branch
3 times, most recently
from
19dc1f0 to
77e89e3
Compare
| public function getVersion() | ||
| { | ||
| if ($this->_version) { | ||
| return $this->_version; |
There was a problem hiding this comment.
Is there a reason you "cache" the version? Do you expect that this call is happening more then once during the lifetime of a Client?
There was a problem hiding this comment.
It's possible. Imagine two repositories: A, B both are using ES, both should be B/C with 1.7 and 2.0.
|
Thanks, definitively a useful addition. See my comments above. |
- updated ChangeLog
oleg-andreyev
force-pushed
the
version-method
branch
from
e2bb4e9 to
ab1b847
Compare
oleg-andreyev
force-pushed
the
version-method
branch
from
9cee880 to
0abec0e
Compare
|
@oleg-andreyev Thanks. Merged. This will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding
getVersionmethod to Client.Case: For large platforms it's critical to upgrade incrementally/step-by-step, for this purpose we need to know current version on ES