Allow strings for setMinimumMatch in Terms query #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you also update the changelog? |
|
I'm curious why Travis did not start on this PR? |
|
@ruflin Sure, will do |
|
@ruflin Done |
|
Seems like Travis is now willing to test the changelog |
| /** | ||
| * @group unit | ||
| * @dataProvider provideMinimumArguments |
There was a problem hiding this comment.
It would be nice to also have this for an integration test to make sure it also works with the current elasticsearch version. but we can add this in an other PR.
|
Merged. Thanks |
| @@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file based on the | |||
|
|
|||
| ### Bugfixes | |||
| - Set HTTP headers on each request preventing server error if persistent connection is enabled and compression enabled and later disabled for the same connection. | |||
| - Removed `int` type hinting in `setMinimumMatch` (`Terms` Query): it should also allow `string`. [#1151](https://github.com/ruflin/Elastica/pull/1151) | |||
There was a problem hiding this comment.
I will probably move this to improvements before the next release as I don't think it was a "bug". The limitation was more for historical reasons.
There was a problem hiding this comment.
Sure - I just considered as a bug because the expected behaviour was not meeting the functional one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1149