Get the root reason from elasticsearch's json when available #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgalbu
changed the title
| if (isset($error['root_cause'][0])) { | ||
| $error = $error['root_cause'][0]; | ||
| $root_error = $error['root_cause'][0]; |
There was a problem hiding this comment.
Could you use $rootError for the name here to adhere to our naming standard?
|
LGTM. One minor comment about the naming. Could you please also update the CHANGELOG.md? And if possible, rebase it on master. That will fix the broken 5.4 build. |
maxgalbu
force-pushed
the
get-other-error-reason
branch
from
2a2aad2 to
ea5e992
Compare
|
@maxgalbu Oh, Github started to send notifications for new commits. Not sure if this is complete yet, but you missed the CHANGELOG.md part ;-) |
|
you're right, I had a brief moment of pause at work so I did the quick fix :) |
maxgalbu
force-pushed
the
get-other-error-reason
branch
from
ea5e992 to
41ec4b2
Compare
|
Merged. Thanks a lot for the improvement. Unfortunately I already made the 3.2.1 release today in the morning, so it will go into the next minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes elasticsearch (i'm using 2.3.3) returns an error with two reasons:
{ "error": { "root_cause": [ { "type": "index_creation_exception", "reason": "failed to create index" } ], "type": "illegal_argument_exception", "reason": "synonym requires either `synonyms` or `synonyms_path` to be configured" }, "status": 400 }But the current code uses only the "root_cause" reason, leaving me with an exception that says "failed to create index" and not much else. This change uses the "root" reason key if it exists.