Fix Query::addScriptField() #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like it's failed because it wasn't able to pull docker images? |
|
I restarted the failing builds. |
|
@s12v Could you update the CHANGELOG.md file? |
script_fields must have type ScriptFields update CHANGELOG.md
|
@ruflin, done |
|
@s12v Merged. Thanks. |
|
@ruflin, would it be possible to have a new release including this change? |
|
@s12v Sure, will push 3.2.1 |
|
@s12v The release is currently somehow blocked because of this composer issue: #1096 (comment) any help is appreciated. |
|
@s12v No release yet as the PHP 5.4 builds are still red. Somehow hesitant to release with these red. |
|
@ruflin, thank you for the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
$query->setScriptFields(...)$query->addScriptField(...)After calling
setScriptFields(...),$this->_params['script_fields']has typeScriptFields, therefore$this->_params['script_fields'][$name]fails