fix-update-document-options-not-set

[olchick]

Comes from 1046

Improvement for updateDocument method: not set option 'retry_on_conflict' if it is empty in Client's config.

[ewgRa]

@olchick For me it seems like broke BC.

For now Elastica always sends retry_on_conflict=0 by default. With your PR it will be taken from elasticsearch configuration and it can be not 0, for such developers it will be broke BC.

More right make something like "unsetConfig('retry_on_conflict')" or "setConfig('retry_on_conflict', null)" and than client can omit it when perform request.

Also what with 'version' field from original issue? I think if Amazon care about "retry_on_conflict" it will be also raise errors for "version", and your PR solve only retry_on_conflict.

[Tobion]

@ewgRa retry_on_conflict=0 is the default in ES. How is that possible to change that?

[ewgRa]

@Tobion https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update.html#_parameters_2

retry_on_conflict there

Or I misunderstand your question?

[Tobion]

You said there is a configuration which can be changed and due that not sending the default value would be a BC break for those people.

With your PR it will be taken from elasticsearch configuration and it can be not 0, for such developers it will be broke BC.

So what configuration are you talking about?

[ewgRa]

@Tobion you are right. By default it is "the update will fail with a version conflict exception", if it is omitted, also like "default", and all this work as "0".

So, there is will be no BC break.

[Tobion]

Good, then I think this is good to be merged.

[ruflin]

@Tobion Didn't check this one in detail. If it looks good, feel free to merge. @olchick Can you potentially add an entry to the changelog?

[Tobion]

Added changelog