Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Elastica\Query::setSource() : wrong signature #818

Closed
mfn opened this issue Apr 21, 2015 · 1 comment
Closed

\Elastica\Query::setSource() : wrong signature #818

mfn opened this issue Apr 21, 2015 · 1 comment

Comments

@mfn
Copy link
Contributor

mfn commented Apr 21, 2015

The current signature reads:

    /**
     * Sets the _source field to be returned with every hit
     *
     * @param  array           $fields Fields to be returned
     * @return \Elastica\Query Current object
     * @link   http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/search-request-source-filtering.html
     */
    public function setSource($fields)

From http://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-source-filtering.html :

To disable _source retrieval set to false:

{
    "_source": false,
    "query" : {
        "term" : { "user" : "kimchy" }
    }
}

This is currently not possible due the array signature.

ruflin added a commit that referenced this issue Apr 24, 2015
Allow bool in Query::setSource function #818
@ruflin
Copy link
Owner

ruflin commented Apr 24, 2015

Close as fixed in #823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants