Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GlobalWorkspace to GlobalWorkspaceFusion #189

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

bdvllrs
Copy link
Collaborator

@bdvllrs bdvllrs commented Nov 22, 2024

As discussed in a meeting, We reserve the name GlobalWorkspace for a future model.
For now, GlobalWorkspace2Domains should be favoured to replicate the result of the paper: https://ieeexplore.ieee.org/abstract/document/10580966

@bdvllrs bdvllrs requested a review from a team November 28, 2024 10:30
@bdvllrs bdvllrs changed the title Rename GlobalWorkspace te GlobalWorkspaceFusion Rename GlobalWorkspace to GlobalWorkspaceFusion Nov 29, 2024
Copy link
Collaborator

@leopoldmt leopoldmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@leopoldmt leopoldmt merged commit cbd16cb into main Nov 29, 2024
2 checks passed
@bdvllrs bdvllrs deleted the rename-default-gw branch November 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants