AVM1: Delay clip removals when an unload listener is present#8873
Merged
kmeisthax merged 6 commits intoruffle-rs:masterfrom Feb 6, 2023
Merged
AVM1: Delay clip removals when an unload listener is present#8873kmeisthax merged 6 commits intoruffle-rs:masterfrom
kmeisthax merged 6 commits intoruffle-rs:masterfrom
Conversation
Herschel
reviewed
Dec 20, 2022
Herschel
reviewed
Dec 20, 2022
CUB3D
force-pushed
the
delayed_clip_removal
branch
from
ea4338b to
8d1fdd7
Compare
Dinnerbone
approved these changes
Jan 10, 2023
Dinnerbone
force-pushed
the
delayed_clip_removal
branch
from
8d1fdd7 to
c57aaed
Compare
Collaborator
|
This might fix #5928. |
When removing a clip, first check if it has an unload event listener somewhere it's hierarchy. If it does, enqueue the removal to happen on the next frame, by moving it to a negative depth.
CUB3D
force-pushed
the
delayed_clip_removal
branch
from
93ec622 to
b884609
Compare
kmeisthax
approved these changes
Feb 6, 2023
This was referenced Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in #1535, when a clip is removed in AVM1, it may be retained for an extra frame if it contains an unload handler.
This is an attempt to make the behavior of Ruffle better match that of Flash Player by moving these clips to a negative depth, that will be removed at the start of the next frame.
This matches the behavior in the example given in #1535 and resolves the issue in #2287.
TODOs: