Read SWF avm1 actions without unnecessary allocations #3203
+521
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
changed the title
madsmtm
force-pushed
the
swf-avm1-no-alloc
branch
from
7c7c409 to
cb2f035
Compare
|
The tests are currently failing on |
madsmtm
force-pushed
the
swf-avm1-no-alloc
branch
from
cb2f035 to
1d70a2d
Compare
madsmtm
force-pushed
the
swf-avm1-no-alloc
branch
from
1d70a2d to
bf8d092
Compare
danielhjacobs
added
swf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some work on making avm1 SWF parsing non-allocating and more efficient. We now read
OpCodeinActivation::do_action, and then call the SWF parsing functions on theswf::avm1::Readerdirectly, bypassing the need for theswf::avm1::Actionenum - as discussed on Discord.This also allows us to use iterators in e.g.
OpCode::Push, which is otherwise quite difficult since the iterators have to consume bytes from the reader before parsing the next action.