Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Associate Ruffle window with Ruffle #19308

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Jan 22, 2025

This patch associates the main window created by Ruffle with the Ruffle application by its ID.

This fixes issues on some desktops (KDE, Wayland) where the window is not being recognized as Ruffle.

@kjarosh kjarosh added A-desktop Area: Desktop Application linux T-fix Type: Bug fix (in something that's supposed to work already) labels Jan 22, 2025
@torokati44
Copy link
Member

What does this require to be installed? The .desktop file?

@kjarosh
Copy link
Member Author

kjarosh commented Jan 22, 2025

What does this require to be installed? The .desktop file?

I believe so, although maybe the icon itself is enough? Who knows, these things differ for various environments, GNOME might do it differently than KDE, etc.

The good thing is that the class is unique, so we won't cause any conflicts + it should be ignored when there's no such application.

This patch associates the main window created by Ruffle with the Ruffle
application by its ID.

This fixes issues on some desktops (KDE, Wayland) where the window is
not being recognized as Ruffle.
@kjarosh kjarosh added the waiting-on-review Waiting on review from a Ruffle team member label Jan 22, 2025
Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, works for me too, thanks!

@kjarosh kjarosh merged commit 46aa652 into ruffle-rs:master Jan 23, 2025
22 checks passed
@kjarosh kjarosh deleted the window-class branch January 23, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application linux T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon to Wayland window (Linux)
2 participants