Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: Remove unused PartialEq impls from shape_utils #16905

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aaron1011
Copy link
Member

These impls were unused, and I don't think we should ever be doing a 'deep comparison' of things like DistilledShape

These impls were unused, and I don't think we should ever
be doing a 'deep comparison' of things like `DistilledShape`
@torokati44
Copy link
Member

Well, at least the one on DrawPath seems to be needed for/by tests.

@Aaron1011
Copy link
Member Author

Oops - I ran cargo test -p tests locally, but forgot about unit tests.

@Aaron1011 Aaron1011 marked this pull request as draft June 27, 2024 19:56
@evilpie
Copy link
Collaborator

evilpie commented Jun 30, 2024

You could only derive PartialEq for cfg(test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants