-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avm2: Class refactor #16783
Open
Lord-McSweeney
wants to merge
18
commits into
ruffle-rs:master
Choose a base branch
from
Lord-McSweeney:avm2-class-refactor-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
avm2: Class refactor #16783
Lord-McSweeney
wants to merge
18
commits into
ruffle-rs:master
from
Lord-McSweeney:avm2-class-refactor-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-class-refactor-1
branch
2 times, most recently
from
June 20, 2024 19:28
7570dc7
to
4bfbff5
Compare
Lord-McSweeney
force-pushed
the
avm2-class-refactor-1
branch
from
June 21, 2024 00:07
72b5da1
to
745fb79
Compare
This requires changing the AVM2 ClassObject symbol registry to use Classes
Lord-McSweeney
force-pushed
the
avm2-class-refactor-1
branch
from
July 1, 2024 13:53
02babfe
to
c227ff9
Compare
Lord-McSweeney
added
waiting-on-review
Waiting on review from a Ruffle team member
labels
Jul 2, 2024
…ts traits already loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors classes to match avmplus, which simplifies a lot of Class-related stuff and improves the optimizer.
Notable changes:
Class
es for every class. One holds the instance info, while the other holds the class info. Each of them holds a link to the other.init_instance_vtable
is now called from withinClassObject::from_class_partial
ClassObject
now delegates toClass
for the instance allocatorClassObject
no longer stores its class vtable on itselfTraitKind::Class
slots on vtables are now properly typed (this should help some optimizations)ScriptObjectData
now stores a Class instead of a ClassObject to represent its constructordescribeType
is simplifiedinstance_class
isn'tOption
al anymorevoid
no longer has a ClassObjectBox2d optimization stats: