Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Allow ShaderParameter value to be null #16748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aaron1011
Copy link
Member

This makes progresss in on #441

@evilpie
Copy link
Collaborator

evilpie commented Jun 17, 2024

I am not sure if Flash actually copies the array.

var param = new ShaderParameter();
var array = [.1, .1, .1, .1];
param.array = array;
trace(param.array == array); // true
trace(param.array == param.array); // true

@danielhjacobs danielhjacobs added the A-avm2 Area: AVM2 (ActionScript 3) label Jun 20, 2024
@Lord-McSweeney Lord-McSweeney added the waiting-on-author Waiting on the PR author to make the requested changes label Jul 5, 2024
@danielhjacobs danielhjacobs added the T-fix Type: Bug fix (in something that's supposed to work already) label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-author Waiting on the PR author to make the requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants