core: Don't reborrow UpdateContext constantly, add a new lifetime to Activation to track the borrow #16737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
changed the title
|
Closed in favour of #17345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is mostly noise from adding one more lifetime to Activation, making the signature go from
Activation<'a, 'gc>toActivation<'player, 'update, 'gc>.Should reduce stack size of making activations, and ideally a small performance boost too.
Size of AVM1
Activation(on 64-bit) goes from 616 bytes to 120Size of AVM2
Activation(on 64-bit) goes from 760 bytes to 296